Update view tests to the new pattern everywhere#1157
Merged
johnboiles merged 4 commits intomainfrom Oct 13, 2025
Merged
Conversation
81cfb5e to
35f4445
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this makes view tests more reliable.
I decided to change the pattern from #1155 to instead have
WAIT_FOR_DRAWtake an optional parameter that determines whether the UI continues to run after. After a weekend of thinking about it I liked this better because thenWAIT_FOR_DRAWis the only place that we wait for a draw to occur. It felt a little funky to me to combineWAIT_FOR_DRAWintoASSERT_VIEW_UNCHANGEDbut only sometimes.I did this mostly with regexes:
Find the recent new style used only in Kindle tests
Replace with
Find WAIT_FOR_DRAW with ASSERT_VIEW_UNCHANGED afterwards
Replace with
Sanity check lines with WAIT_FOR_DRAW not followed by ASSERT_VIEW_UNCHANGED or WAIT_FOR_DRAW
Check and cleanup manually